<html>
<head><meta charset="utf-8"><title>lang team review request · t-lang/doc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/index.html">t-lang/doc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html">lang team review request</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="226288300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/226288300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> isHavvy <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#226288300">(Feb 14 2021 at 06:13)</a>:</h4>
<p><a href="https://github.com/rust-lang/reference/pull/874">https://github.com/rust-lang/reference/pull/874</a> is stuck waiting on somebody to agree that the specified case is indeed invariant. Anybody on the lang team want to give their credence to this?</p>



<a name="226436570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/226436570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#226436570">(Feb 15 2021 at 22:15)</a>:</h4>
<p>We might need to ping <span class="user-group-mention" data-user-group-id="1977">@T-lang</span> because i'm not sure how many of them are subscribed to this stream.</p>



<a name="227336830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/227336830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#227336830">(Feb 22 2021 at 21:03)</a>:</h4>
<p>I'm subscribed but i'm behind on notifications :)</p>



<a name="227336900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/227336900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#227336900">(Feb 22 2021 at 21:03)</a>:</h4>
<p>does the docs use bors?</p>



<a name="227337227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/227337227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#227337227">(Feb 22 2021 at 21:06)</a>:</h4>
<p>The reference does not.  Just click the merge button, or if you leave an "approved" review I can click it.</p>



<a name="232554359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/232554359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#232554359">(Mar 31 2021 at 08:35)</a>:</h4>
<p>I'm reviewing <a href="https://github.com/rust-lang/nomicon/pull/259">https://github.com/rust-lang/nomicon/pull/259</a> and I'd appreciate it if someone from the T-lang could also review it since it's a major change. This adds a step-by-step example to the "Send and Sync" chapter</p>



<a name="232554983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/232554983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> isHavvy <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#232554983">(Mar 31 2021 at 08:41)</a>:</h4>
<p>(Not a lang team member) A cursory look at the two examples don't show anything wrong to me. It looks more like a step b step example for making a Box-like moreso with Send and Sync being incidental than an actual step-by-step guide for Send and Sync.</p>



<a name="232556244"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/232556244" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#232556244">(Mar 31 2021 at 08:52)</a>:</h4>
<p>thanks for checking! yeah, but I think it's the best place to put this example except for creating a new chapter</p>



<a name="233780938"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/233780938" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#233780938">(Apr 09 2021 at 07:43)</a>:</h4>
<p>Another one: <a href="https://github.com/rust-lang/nomicon/pull/223">https://github.com/rust-lang/nomicon/pull/223</a><br>
The implementation looks good to me but I'm afraid that I cannot have time to read more carefully so it'd be great if someone could also check it, thanks :)</p>



<a name="233869165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/233869165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#233869165">(Apr 09 2021 at 18:26)</a>:</h4>
<p>I don't think review on that one would be limited to lang folks; you might actually want to get a library person to look at that.</p>



<a name="235416837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/235416837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#235416837">(Apr 20 2021 at 21:09)</a>:</h4>
<p>hmm</p>



<a name="235416906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/235416906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#235416906">(Apr 20 2021 at 21:10)</a>:</h4>
<p>I don't think I have nomicon in my lang-team triage script</p>



<a name="244209117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/244209117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#244209117">(Jun 28 2021 at 21:51)</a>:</h4>
<p>Could someone take a look at  <a href="https://github.com/rust-lang/reference/issues/841">rust-lang/reference#841</a>? The explanation seems to match the behavior but I'm not sure if it's entirely correct or we should document in more detail</p>



<a name="244375264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/244375264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#244375264">(Jun 30 2021 at 04:05)</a>:</h4>
<p>The explanation does seem to match the behavior. I find myself wondering what happens if you try to use a generic type <em>in</em> the static...</p>



<a name="244375898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/244375898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#244375898">(Jun 30 2021 at 04:19)</a>:</h4>
<p>Ah, just got the answer:</p>
<blockquote>
<p>error[E0401]: can't use generic parameters from outer function</p>
</blockquote>



<a name="244376178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/244376178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#244376178">(Jun 30 2021 at 04:25)</a>:</h4>
<p>Posted a comment.</p>



<a name="244383093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/244383093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#244383093">(Jun 30 2021 at 06:44)</a>:</h4>
<p>Thanks!</p>



<a name="244419716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/lang%20team%20review%20request/near/244419716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Connor Horman <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/lang.20team.20review.20request.html#244419716">(Jun 30 2021 at 13:04)</a>:</h4>
<p>(deleted)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>